Benjamin Bojko
Benjamin Bojko
A central spot, possibly a static array or enum in the `Command` class makes the most sense to me. That way we could use a simple filter/reduce function to configure...
PS: renamed the ticket to make it more actionable/clear what this is about
It felt like this could be a fairly targeted incision, but I hear you on it feeling like it might have implications. It doesn't seem like it would limit functionality...
Hmm that's a good question. Technically yes, there should only be one instance. The only other actual singleton right now is the `LogManager` class. I wonder if we should make...
This is great, thanks for putting so much thought toward this. A few initial reactions below: > So a couple of thoughts: > > * Can we call this the...
Thanks for pushing on this and giving this more thought! Super helpful to have something to look at and discuss. I'd like to hear more about what you were thinking...
> Should it be run, based on config, when you just run npx launchpad? That's what I had hoped for. If we can keep it lightweight enough, it feels like...
[bcryptjs](https://www.npmjs.com/package/bcryptjs) sounds great! So we'd just be storing the hash/salt and not the password? Let's go with Transports! As you said, that's what Winston uses too and it feels applicable...
Oh and for now let's go with one of the json file options for storing session info. Any thoughts on what that file could be named? What are people using...
Ok sounds good. Might be nice to have some way to auto-generate a local salt. I was also wondering if it would make sense to switch up our credentials format...