typeorm-cursor-pagination icon indicating copy to clipboard operation
typeorm-cursor-pagination copied to clipboard

fix: remove paginationUniqueKey option

Open benjamin658 opened this issue 3 years ago • 1 comments

benjamin658 avatar Jul 22 '22 03:07 benjamin658

Codecov Report

Base: 86.11% // Head: 88.72% // Increases project coverage by +2.61% :tada:

Coverage data is based on head (0902691) compared to base (e233c85). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   86.11%   88.72%   +2.61%     
==========================================
  Files           4        4              
  Lines         144      133      -11     
  Branches       30       27       -3     
==========================================
- Hits          124      118       -6     
+ Misses         10        5       -5     
  Partials       10       10              
Impacted Files Coverage Δ
src/utils.ts 70.96% <ø> (+7.80%) :arrow_up:
src/Paginator.ts 92.77% <100.00%> (-0.26%) :arrow_down:
src/buildPaginator.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Jul 22 '22 03:07 codecov-commenter

I'd like to see this released. We're having issues with our pagination.

If you want I can provide anonymised sample data. I should be getting about 900+ rows from our pagination (until the last page is reached), but I only receive ~300.

ruben-treams avatar Oct 10 '22 13:10 ruben-treams

It seems to cause some weird bug, let's release it.

benjamin658 avatar Oct 31 '22 01:10 benjamin658