chrome-okc-plugin
chrome-okc-plugin copied to clipboard
benjaffe
BetterCupid extensions seems to keep labels from persisting
FYI, Enabling the BetterCupid extension seems to somehow erase labels like Poly or Message. They just disappear on refresh. Unfortunately they don't come back when BetterCupid is disabled either.
Just something to be aware of, I'm not sure how many people use it (it doesn't seem to do much).
Yes indeed, the BetterCupid extension uses localStorage.clear(), which IMO is irresponsible... it totally nukes anything OkC or anyone else sets in localStorage. The only thing I can think to do is to override localStorage.clear. That may be something I look into in the future, but for now, sadly, users will have to choose between this extension and BetterCupid. I put a note closer to the end of the extension's description in the Chrome store, but I don't think many people read that far. :)
On Sun, Jun 15, 2014 at 4:32 PM, David Rees [email protected] wrote:
FYI, Enabling the BetterCupid https://chrome.google.com/webstore/detail/bettercupid/egdnnbehcfaogopbgaanfnmpgdpkeloo extension seems to somehow erase labels like Poly or Message. They just disappear on refresh. Unfortunately they don't come back when BetterCupid is disabled either.
Just something to be aware of, I'm not sure how many people use it (it doesn't seem to do much).
— Reply to this email directly or view it on GitHub https://github.com/benjaffe/chrome-okc-plugin/issues/87.
Ben Jaffe • Developer, Instructor, GeekSpeak, KUSP 510.545.2365 • benjaffe.me • Github https://github.com/benjaffe/ •
LinkedIn https://www.linkedin.com/in/benjaffe
I hadn't realized that, I guess its because its running as an injected script?
I added an issue for BetterCupid at https://github.com/michaeldrotar/Better-Cupid/issues/2.
They should be just deleting the keys they're using, rather than nuking the entire storage mechanism. :)
On Tue, Jun 17, 2014 at 5:37 PM, David Rees [email protected] wrote:
I hadn't realized that, I guess its because its running as an injected script?
I added an issue for BetterCupid at michaeldrotar/Better-Cupid#2 https://github.com/michaeldrotar/Better-Cupid/issues/2.
— Reply to this email directly or view it on GitHub https://github.com/benjaffe/chrome-okc-plugin/issues/87#issuecomment-46383462 .
Ben Jaffe • Developer, Instructor, GeekSpeak, KUSP 510.545.2365 • benjaffe.me • Github https://github.com/benjaffe/ •
LinkedIn https://www.linkedin.com/in/benjaffe
Agreed. This stack overflow answer implies you might be able to use chrome.storage instead from a content script, which would avoid BetterCupid and also provide sync of settings. Or use the message passing approach.
chrome.storage doesn't provide sync, but chrome.sync does. chrome.storage seems less accessible as a developer though (can't access through the console while debugging, etc), and I didn't see a huge reason to use it unless I was ready to implement sync (which I haven't had time for recently).
On Tue, Jun 17, 2014 at 5:48 PM, David Rees [email protected] wrote:
Agreed. This stack overflow answer http://stackoverflow.com/a/21066312/255961 implies you might be able to use chrome.storage instead from a content script, which would avoid BetterCupid and also provide sync of settings. Or use the message passing approach.
— Reply to this email directly or view it on GitHub https://github.com/benjaffe/chrome-okc-plugin/issues/87#issuecomment-46384101 .
Ben Jaffe • Developer, Instructor, GeekSpeak, KUSP 510.545.2365 • benjaffe.me • Github https://github.com/benjaffe/ •