chrome-okc-plugin icon indicating copy to clipboard operation
chrome-okc-plugin copied to clipboard

Published 20 hours ago • verified publisher icon benjaffe

Make into WebExtension compatible with Firefox

Open joallard opened this issue 7 years ago • 5 comments

Follows comments on #168

joallard avatar Apr 18 '17 01:04 joallard

I'm happy to merge this. I'll release the chrome update sometime this weekend, possibly next week (things are a bit hectic), but since it's a small styling change, a slower release shouldn't be a big deal.

@joallard, any other things you're working on for this PR, or is it good to go?

benjaffe avatar Apr 20 '17 02:04 benjaffe

I was trying to remove the dependency on Bower, but I'm not that well versed in js to know what the good practices are in 2017. I had a WIP locally, I'll try to add that and we'll be good to go.

joallard avatar Apr 20 '17 19:04 joallard

Any progress on this? I'm looking to contribute as well, and it would be nice to not have the bower dependency if possible

brenthaas avatar Oct 02 '17 22:10 brenthaas

While I agree, I'll leave Bower out of scope for this PR as it pretty much gums up the works. Expect an update to this PR along with a final LGTM. Soon.

joallard avatar Oct 04 '17 05:10 joallard

Any progress?

Since Firefox Quantum got released a few days back I looked into installing this addon through Foxified. The addon tries to upload the okc-plugin to Mozilla but it got rejected due to several problems.

This means I still would like to see this issue be successful...

instantgreen avatar Nov 25 '17 20:11 instantgreen