seeks icon indicating copy to clipboard operation
seeks copied to clipboard

Extended messages cannot have required fields (must be optional).

Open Quix0r opened this issue 10 years ago • 6 comments

There is an error when I use the proto file db_query_record_msg.proto:

db_query_record_msg.proto:36:11: Message extensions cannot have required fields. /home/quix0r/git/seeks/src/plugins/query_capture/Makefile:850: recipe for target 'db_query_record_msg.pb.cc' failed make: *** [db_query_record_msg.pb.cc] Error 1

This small change fixes it.

Quix0r avatar Dec 06 '14 13:12 Quix0r

Thanks. this might be due to using a new protocol buffer version. What version are you using ?

beniz avatar Dec 06 '14 13:12 beniz

$ protoc --version libprotoc 2.6.0 $

Is my change working with older versions? Then, I think, it is save to merge. :-)

Quix0r avatar Dec 07 '14 14:12 Quix0r

:-( All commits end up here in one merge request ...

Add more commits by pushing to the master branch on Quix0r/seeks.

They should have made this notice bigger.

Quix0r avatar May 22 '15 03:05 Quix0r

Thanks, I'll take time to review this.

beniz avatar May 22 '15 04:05 beniz

My apologies I was taken elsewhere and missed this PR. Is this still relevant ? Are you using Seeks ?

beniz avatar Feb 06 '16 19:02 beniz

I am using Seeks every day. I am willing to test whatever there is to test in this PR.

GreenLunar avatar Feb 06 '16 20:02 GreenLunar