jekyll-exiftag icon indicating copy to clipboard operation
jekyll-exiftag copied to clipboard

This works great for JPG but PNG doesn't seem to be working?

Open 888ba8 opened this issue 4 years ago • 1 comments

@benib

Have you looked into the possibility of including PNGs as well? Thumbnail generation is looking great for PNGs, no problems there.

The {% exiftag image_description %} however doesn't seem to be working at the moment. Instead, the filepath is shown for PNGs, while JPGs show the correct caption from the ImageDescription. I am changing the ImageDescription with some ExifTool, so I can verify that the metadata is correct. But somehow {% exiftag image_description %} isn't retrieving that for the PNGs.

Greetings!

888ba8 avatar Jan 09 '21 23:01 888ba8

hei @888ba8

Actually I haven't used jekyll and jekyll-exiftag myself since many years. As far as I see, EXIFR (the lib used by jekyll-exiftag) supports JPEG and TIFF only, and jekyll-exiftag even hardcodes to use JPEG. That is why you don't get the tags extracted.

To make this work, EXIFR would need to support PNG and jekyll-exiftag would need to be patched to not hardcode the usage of JPEG but decide based on mime type what to do with the file.

benib avatar Jan 12 '21 00:01 benib