Ben Grynhaus
Ben Grynhaus
> Hi @bengry! Could you please provide a StackBlitz or CodeSandbox with the code you're trying to implement and its current behavior? This will help determine if `CheckboxCheck` is indeed...
> It seems that `CheckboxCheck` is not suitable for your use case. Simply get the checked state from the menu store and render your custom checkmark without `CheckboxCheck`: Thanks, this...
Hey @aleclarson, thanks for reaching out! I'll look into Radashi and get back to you, sounds interesting.
Thanks for the detailed response! > Thanks for reporting. Ariakit has a [`preventBodyScroll`](https://ariakit.org/reference/dialog#preventbodyscroll) logic that's more robust to ensure nested dialogs work properly. That's likely one of the reasons. We...
@diegohaz I found another issue related to this, in addition to the `preventBodyScroll` - it seems like the backdrop's `z-index` [is calculated](https://github.com/ariakit/ariakit/blob/9584251e9ec6cb2c3e015f1ea45f7cb3b58783b3/packages/ariakit-react-core/src/dialog/dialog-backdrop.tsx#L30) based on the Dialog's one. Calling `getComputedStyle` like...
> @bengry I also noticed this `getComputedStyle` while working on a new dialog example. I wonder if using `useEffect` instead of `useLayoutEffect` helps here: I'm not sure about the ~`useLayoutEffect`~...
> Both `z-index` orchestration and `backdrop` will be unnecessary once we start using native popovers. But we still need to wait for the ecosystem to adapt. See [x.com/diegohaz/status/1711889981013209541](https://x.com/diegohaz/status/1711889981013209541) For sure,...
> This is probably the same issue as #4100 and #3402 and should be resolved in `v0.5.0`. > > The workaround is to manage other triggers for this behavior, such...
> Thanks for contribution. > > Is it possible to write a unit test to cover this case? Thanks for the quick response. I added a test in the latest...
@thekip @vonovak no pressure or anything, but anything blocking this PR from being merged now? We could really use a new version with this fix. If that's not coming soon...