vscode-node-readme
vscode-node-readme copied to clipboard
`package` package opened when input box canceled
The following line doesn't account for cancellation:
https://github.com/bengreenier/vscode-node-readme/blob/89b2d6fdb324e55870fd15eee599dabc80136ad2/src/commands/showReadme.ts#L21
In theory that should pass findReadme(undefined)
then attempt to open https://npmjs.org/package/undefined
(I guess) but instead opens https://npmjs.org/package/
which npm interprets as the package
package.
A related issue is the key binding should only be triggered when "editorLangId == 'javascript' || ..."
.
Hi @texastoland thanks for flagging this one - I haven't updated this plugin in a while, but will take a look at including fixes for these things in any upcoming release. In the meantime, feel free to PR any changes, would be happy to review those.
I'll give it a shot 🔜