benfurber
benfurber
Would love for this to be merged in so that I move a site over to netlify. 🙏
@Robert-LC Let's sync and give the testing one more go in a follow-up PR. As the feature seems to work, I'll tidy-up in the branch to get CI passing so...
@all-contributors please add @Robert-LC for code
So what do you think @davehakkens - worth getting the illustrator to polish this up?
Just realised you've responded on https://github.com/ONEARMY/community-platform/discussions/3236. I'll start implementing a simple message version of this without the updated illustrations.
Thanks for looking into this @CubeLuke! I think a spinner is fine. Can I assign you the issue?
I was going to prepare this before adding the donation stage, but I realise I'm needing to add context to the modal to test my changes, so I think adding...
Hey @Robert-LC hope you're well, will you have a chance to have a look at this again soon?
That's great @EdwardAndress! Thanks for picking this up!
@EdwardAndress This might be worth a look/related: https://github.com/ONEARMY/community-platform/pull/3417 Of course I haven't seen your testing approach yet but I imagine that's also the test file that you'll need to update.