benfred
labels overlap when circles don't overlap
There are situation when there is no overlap between Venn diagram circles, in such case the algoritm lays them out horizontally aligned. This causes labels to overlap, if they have a certain length.
Any tip on how to work around this?
Can you provide the input that causes this? The labels should be wrapping on word breaks when they get too long now.
Details of this changes are here, but it should look something like:
when the labels get too long
Problem occurs when the label is only one long word for a small circle. The wrapping logic uses space characters to split the label, so nothing wraps in such cases.
In case someone also has this problem and looks for a solution:
I've worked around the issue by shifting vertically the overlapping labels.
This method works:: https://blog.safaribooksonline.com/2014/03/11/solving-d3-label-placement-constraint-relaxing/, in our case it's better to use getBBox() to detect the overlap instead of simply comparing vertical positions.
One more label issue. A should come on outer circle.
var sets = [ {sets: ['A'], size: 4},{sets: ['B'], size: 3},{sets: ['A','B'], size: 4}];
Right now I'm sampling a bunch of points in the venn diagram, and then taking the average of all the points in each region to be the centre of that region (which is where the label is placed).
This works ok in a bunch of cases, but totally breaks down in situations like these. The problem here is the 'A' region is a crescent shape - and the centre of the crescent it is outside of itself (where the label is placed). I've some ideas in fixing this (like take the mediod point, instead of mean point - or if the point is outside its own region, then take average in polar coordinate space etc). I'll see if I can grab some time on the weekend to come up with a solution here.
@sumanparia that issue with the labelling issue should be fixed by commit 3d281c9, output after that commit is:
this still leaves the problem with labels being cut off, leaving open for now
In case someone also has this problem and looks for a solution:
I've worked around the issue by shifting vertically the overlapping labels.
This method works:: https://blog.safaribooksonline.com/2014/03/11/solving-d3-label-placement-constraint-relaxing/, in our case it's better to use
getBBox()to detect the overlap instead of simply comparing vertical positions.
Just wanted to add in case anyone came across this (or #61) and like me had trouble figuring it out, here's an example of how I got the above suggestion (minus getBBox) to work.
Also the site seems to be down; here's an archived link.
