venn.js
venn.js copied to clipboard
benfred
issue on v0.2.9
would it be possible to correct this? i'm trying to get the package pushed to cdnjs cdnjs/cdnjs#12418 and they don't love this issue
$ diff venn.js build/venn.js
921,949d920
< /// Uses multidimensional scaling to approximate a first layout here
< function classicMDSLayout(areas) {
< // bidirectionally map sets to a rowid (so we can create a matrix)
< var sets = [], setids = {};
< for (var i = 0; i < areas.length; ++i ) {
< var area = areas[i];
< if (area.sets.length == 1) {
< setids[area.sets[0]] = sets.length;
< sets.push(area);
< }
< }
<
< // get the distance matrix, and use to position sets
< var distances = getDistanceMatrices(areas, sets, setids).distances;
< var positions = mds.classic(distances);
<
< // translate rows back to (x,y,radius) coordinates
< var circles = {};
< for (i = 0; i < sets.length; ++i) {
< var set = sets[i];
< circles[set.sets[0]] = {
< x: positions[i][0],
< y: positions[i][1],
< radius: Math.sqrt(set.size / Math.PI)
< };
< }
< return circles;
< }
<
1218a1190,1191
> /*global d3 console:true*/
>
1745c1718
< var version = "0.2.8";
---
> var version = "0.2.9";
1759d1731
< exports.classicMDSLayout = classicMDSLayout;
1775c1747
< }));
---
> }));
\ No newline at end of file
Umm - whats the diff coming from? Seems like the version numbers there are kind of old, latest is 0.2.19 (and the diff there is between 0.2.8 and 0.2.9).
on tag v0.2.9
i'm trying to add the project to cdnjs/cdnjs#12418, but they want this issue corrected. they are looking to pull from npm, anyway the version pushed to npm could be fixed?
They want v0.2.9 fixed? The current version shouldn't have that issue - v0.2.9 is almost 2 years old now
@benfred i know the current version doesn't have an issue, but they host historical versions and maybe it's failing an automated check they have? not 100% sure
if it's not going to happen (because everyone's time is valuable and it's super old), no worries. i was just hoping to deploy this in production and since cdnjs is more popular than jsdelivr, i wanted to locate everything on cdnjs for our site
Hi @benfred I am a member from cdnjs, I think we just need to check which file is correct for [email protected]. Sorry for not noticing the discussion here previously, thanks for you guys' help 😄
