remoteprocess icon indicating copy to clipboard operation
remoteprocess copied to clipboard

Detect statically linked musl using the crt-static target feature, not target_vendor=alpine

Open thomcc opened this issue 3 years ago • 2 comments

Someone reported a bug in the rust-lang zulip about your crate. I happened to notice that you're detecting statically linked musl the wrong way (or, a way that doesn't handle all cases), which is the cause of their bug. This probably fixes the issue for them, so long as they also provide some rustflags when compiling (specifically RUSTFLAGS=-Ctarget-feature=-crt-static to turn off static CRT).

That said, this is extremely a driveby, I haven't tested it beyond being confident that this doesn't break the existing use case, as the alpine target doesn't set crt-static.

thomcc avatar Jan 09 '23 08:01 thomcc

I am porting py-spy to openWRT (another musl based linux distro) and other than the one logic bug, this patch seems to work.

(and seems to be correct based off of https://rust-lang.github.io/rfcs/1721-crt-static.html)

MattCatz avatar Feb 07 '25 18:02 MattCatz

@benfred is there any chance of getting this merged in?

MattCatz avatar Feb 18 '25 01:02 MattCatz