Ben Foster

Results 32 issues of Ben Foster

This was when running the MyNotes example. Not sure if it applies to the core code. `BillingAddress` is defined as a `[ComplexType]` which means it has to be initialised (even...

This PR is in response to [this conversation](https://twitter.com/davidfowl/status/1606060489351614467?s=20&t=BgiVaTJqy23S349buf9asg) with @davidfowl regarding support for polymorphism. With the current implementation, the parameter and corresponding validator types are defined at startup. If a...

It would be useful to capture the email address of the user when authenticating. For google you need to include the "https://www.googleapis.com/auth/email.profile" scope.

As per http://code.google.com/apis/accounts/docs/OAuth2Login.html#userinfocall the "picture" field is not included in the response if a picture does not exist. The current GoogleHandler will therefore throw if a picture doesn't exist. ```...

To support HTML5 `srcset`, `sizes` and `` element it should be possible to define named expressions when configuring an `ImageUrlBuilder` instance. Right now if we were to use `srcset` we'd...

enhancement

`LastIndexOf` doesn't need to read entire string as we know the expected length of an encoded value

Since the value of the underlying `Guid` is never exposed, we could consider using a [Random Number Generator](https://learn.microsoft.com/en-us/dotnet/api/system.security.cryptography.randomnumbergenerator?view=net-6.0) to generate the Id value. This would also have the benefit of...

As discussed, route matching appears to be ignoring the HTTP method. In the test below the GET route is always hit, even when making a POST. ``` namespace Superscribe.Tests.Owin {...