ben fleis
ben fleis
@feichai0017 love it! Thanks for all the follow through, LGTM, tagging it now!
@feichai0017 I misunderstood and misled on the NULL handling, and want to avoid asking you for another round of changes. I'll fork from your branch, and make the final tweaks....
@feichai0017 thanks I'll have a look! I had "quick fixed" it Friday but my CI runs failed massively and I ran out of time to checkout whether it was CI...
@feichai0017 ok, I pulled your latest changes (thank you!) into the PR I had worked on, which itself includes both a few new tests and 1 fix for an edge...