multiline icon indicating copy to clipboard operation
multiline copied to clipboard

Support Java 8

Open rgrigoryev opened this issue 9 years ago • 5 comments

I try to use @Multiline on Java 8 building with gradle and 'net.sf.gapt' plugin, but see in logs following:

warning: No SupportedSourceVersion annotation found on org.adrianwalker.multilinestring.MultilineProcessor, returning RELEASE_6.
warning: Supported source version 'RELEASE_6' from annotation processor 'org.adrianwalker.multilinestring.MultilineProcessor' less than -source '1.8'

Do you have plans about supporting Java 8?

rgrigoryev avatar Nov 14 '15 15:11 rgrigoryev

Those warning messages are benign, i.e. multiline works with Java 8 (Mightly!) , but should be be removed.

peterkittreilly avatar Mar 24 '16 21:03 peterkittreilly

I have figured out how to suppress the Warnings. Apply this patch:

preilly@localhost:~/git/external/multiline/multiline-string (master)$ cat diff.patch diff --git a/multiline-string/src/main/java/org/adrianwalker/multilinestring/JavacMultilineProcessor.java b/multiline-string/src/main/java/org/adrianwalker/multilinestring/JavacMultilineProcessor.java index b821e65..5418da2 100644 --- a/multiline-string/src/main/java/org/adrianwalker/multilinestring/JavacMultilineProcessor.java +++ b/multiline-string/src/main/java/org/adrianwalker/multilinestring/JavacMultilineProcessor.java @@ -6,7 +6,6 @@ import javax.annotation.processing.AbstractProcessor; import javax.annotation.processing.ProcessingEnvironment; import javax.annotation.processing.RoundEnvironment; import javax.annotation.processing.SupportedAnnotationTypes; -import javax.annotation.processing.SupportedSourceVersion; import javax.lang.model.SourceVersion; import javax.lang.model.element.Element; import javax.lang.model.element.TypeElement; @@ -21,7 +20,11 @@ public final class JavacMultilineProcessor extends AbstractProcessor {

    private JavacElements elementUtils;
    private TreeMaker maker;
  •   @Override public SourceVersion getSupportedSourceVersion() {
    
  •           return SourceVersion.latest();
    
  •   }
    
    • @Override public void init(final ProcessingEnvironment procEnv) { super.init(procEnv);

peterkittreilly avatar Mar 24 '16 22:03 peterkittreilly

preilly@localhost:~/git/external/multiline/multiline-string (master)$ cat diff.patch 
diff --git a/multiline-string/src/main/java/org/adrianwalker/multilinestring/JavacMultilineProcessor.java b/multiline-string/src/main/java/org/adrianwalker/multilinestring/JavacMultilineProcessor.java
index b821e65..5418da2 100644
--- a/multiline-string/src/main/java/org/adrianwalker/multilinestring/JavacMultilineProcessor.java
+++ b/multiline-string/src/main/java/org/adrianwalker/multilinestring/JavacMultilineProcessor.java
@@ -6,7 +6,6 @@ import javax.annotation.processing.AbstractProcessor;
 import javax.annotation.processing.ProcessingEnvironment;
 import javax.annotation.processing.RoundEnvironment;
 import javax.annotation.processing.SupportedAnnotationTypes;
-import javax.annotation.processing.SupportedSourceVersion;
 import javax.lang.model.SourceVersion;
 import javax.lang.model.element.Element;
 import javax.lang.model.element.TypeElement;
@@ -21,7 +20,11 @@ public final class JavacMultilineProcessor extends AbstractProcessor {

        private JavacElements elementUtils;
        private TreeMaker maker;
-  
+
+       @Override public SourceVersion getSupportedSourceVersion() {
+               return SourceVersion.latest();
+       }
+
        @Override
        public void init(final ProcessingEnvironment procEnv) {
                super.init(procEnv);

peterkittreilly avatar Mar 24 '16 22:03 peterkittreilly

@peterkittreilly It will be better if you provide a pull request. @benelog Do you accept pull requests?

rgrigoryev avatar Mar 30 '16 16:03 rgrigoryev

@rgrigoryev @rgrigoryev If you send a pull request, I will accept it.

benelog avatar Mar 31 '16 05:03 benelog