mranderson icon indicating copy to clipboard operation
mranderson copied to clipboard

clean up and finalise API

Open benedekfazekas opened this issue 5 years ago • 3 comments

so MrAnderson can be used by a third party, maybe from the REPL to pull in a dep and shadow it.

benedekfazekas avatar Mar 29 '19 16:03 benedekfazekas

(filter u/source-dep? dependencies) should rather happen in leiningen.inline-deps not in mranderson.core. core API is only interested in dependencies to inline

benedekfazekas avatar May 28 '19 13:05 benedekfazekas

Is the following close to what you had in mind?

src/leiningen/inline_deps.clj:

-        paths                     (initial-paths target-path pprefix)]
-    (c/mranderson repositories dependencies ctx paths)))
+        paths                     (initial-paths target-path pprefix)
+        source-dependencies       (filter u/source-dep? dependencies)]
+    (c/mranderson repositories source-dependencies ctx paths)))

src/mranderson/core.clj:

-  [repositories dependencies {:keys [skip-repackage-java-classes unresolved-tree pname pversion overrides] :as ctx} paths]
-  (let [source-dependencies         (filter u/source-dep? dependencies)
-        resolved-deps-tree          (dr/resolve-source-deps repositories source-dependencies)
+  [repositories dependencies
+   {:keys [skip-repackage-java-classes unresolved-tree pname pversion overrides] :as ctx} paths]
+  (let [resolved-deps-tree          (dr/resolve-source-deps repositories dependencies)

sogaiu avatar Nov 24 '19 05:11 sogaiu

yup, i suppose

benedekfazekas avatar Nov 24 '19 08:11 benedekfazekas