hermes-3 icon indicating copy to clipboard operation
hermes-3 copied to clipboard

`sheath_boundary_simple` should warn/error if run with multiple species

Open ZedThree opened this issue 3 months ago • 1 comments

sheath_boundary_simple is only designed for single species and is missing some factors that appear in the full expressions. Unfortunately, it seems that we don't know how many species we have when we construct the component, and only have this information the first time we call transform.

So, questions:

  1. should we warn or error in sheath_boundary_simple if run with multiple species?
  2. if so, is it fine to do so in transform? While doing so in the constructor would be best, this might require a larger refactor of Component and the scheduler
  3. if not, should we detect whether we're running single- or multi-species and include the correct terms as appropriate?

ZedThree avatar Aug 19 '25 13:08 ZedThree

I think 1 and 2 are fine. @bendudson ?

mikekryjak avatar Aug 20 '25 09:08 mikekryjak