Ben Drucker

Results 192 comments of Ben Drucker

Same, haven't touched v2

Cool. Shouldn't be too hard. Any thoughts on unit testing this stuff?

That looks right to me!

I don't think source inspection is even necessary. Provider binaries can report their resources/schema. That's what powers the [`providers schema`](https://www.terraform.io/docs/commands/providers/schema.html) command. Generating a TFLint plugin that supports a single version...

What version of Kubernetes are you running?

Gotcha, seems like there's probably no test coverage for that pod name format anymore. I can look into it in a few.

So the actual pod name is `docker-registry-2-mqe0f` if I'm reading right? Would be a huge help if you could get an entire pod (`kubectl get pod -o yaml`) for confirmation.

I suspect the regression that's affecting you from #78 has to do with the pod template hash. Rather than hardcode error-prone patterns based on string formatting (i.e. strip this part...

From what you posted, the deployment name is `docker-registry-3`. This repo was meant to remove random sections included from Deployments/ReplicaSets, not necessarily any numeric ID. Seems like it was a...

> I'm guessing deployment name wasn't always where the _sourceCategory got his values from. I don't see any reason to assume that #78 was closed by #100. #78 identified bugs...