Ben Drucker

Results 192 comments of Ben Drucker

It's only necessary when you use the OO interface and override `El.prototype.render`. If you go functional, it's not necessary. I'd favor removing the prototype override in a major version bump...

I think it's confusing to let people totally break the render method and then basically offer a way to easily call the original: https://github.com/shama/base-element/blob/981433c5b0dea71360d7b2b79b00bb9dada13605/index.js#L27-L32 I think it's reasonable to: 1....

Thought about this some more and it's still bugging me as a source of confusion. The functional style is presented as an alternative, but it's not really the same. `el.render(callback)`...

Right, totally didn't think of inheriting prototype.render and that elements would no longer have an own property from the constructor.

Hi, I'd welcome a PR. I'm unlikely to have time to look into this but will leave it open for a bit in case you'd like to contribute.

Another possibility would be to make use of the `catch`/[`error`](https://github.com/petkaantonov/bluebird/blob/master/API.md#error-rejectedhandler----promise) distinction in Bluebird. That adds another layer of complexity, but it's a hard problem. You have to hide error messages...

Agreed that using a boolean property to match feels weird but it ends up being the cleanest solution in most cases, especially if Bookshelf eventually depends on Checkit for built...

Yup, check out the Bluebird API docs on `catch`: https://github.com/petkaantonov/bluebird/blob/master/API.md#catchfunction-errorclassfunction-predicate-function-handler---promise. If you pass a function as the first argument to `catch`, it does two things: 1) Checks whether `err instanceof...

Give angular-credit-cards 2.3 a shot. I've added formatting that does a reasonably good job of getting the cursor position right without breaking out of Angular's native input handling events. It's...

I'm going to be working on adding formatting to [angular-credit-cards](https://github.com/bendrucker/angular-credit-cards) today. I don't have an Android device to test on but I'll be running a thorough end to end suite...