Ben Davies

Slevomat ReturnTypeHintSpacing: remove default spacesCountBeforeColon configuration

1

This was changed to zero here: https://github.com/doctrine/coding-standard/pull/163 But this is the default so no need for the override: https://github.com/slevomat/coding-standard/blob/c4e287879af90a2f56b1b516deaba707858c9a24/SlevomatCodingStandard/Sniffs/TypeHints/ReturnTypeHintSpacingSniff.php#L35

Hi there, The following: ```php public function denormalize($data, $type, $format = null, array $context = []): ?Money { if (null === $data) { return null; } if (!isset($data['amount'], $data['currency'])) {...

Performance problem - Rescanning all services during stub registration.

2

Hi there, This plugin is causing a large performance penalty which is most obvious on symfony projects with a large amount of services. This line: https://github.com/psalm/psalm-plugin-symfony/blob/cc89974d16ceda9f7e235e8a74f612e8d3ea44df/src/Handler/ContainerHandler.php#L144 is causing all services...

| Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Tickets | Fixes #402 | License | MIT Only add the...

[Autocomplete] required choice types end up not being required.

8

Hi there, There seems to be an issue with how tom-select is configured, for required, non-multiple choice types. Given a form type configuration like ```php $builder->add('isAttending', ChoiceType::class, [ 'choices' =>...

Hi, Support for [Virtual Scroll](https://tom-select.js.org/plugins/virtual_scroll/) is included in the javascript: https://github.com/symfony/ux/blob/8e84d49a92b70f99001b8817cd3129a6215175f6/src/Autocomplete/assets/src/controller.ts#L131 But there is no support in the default php implmentation. Basically, the backend needs to support pagintion fo the...

Array shape is forgotten by adding some conditionals.

3

# Bug report It seems phpstan is "forgetting" the shape of an array by just adding 2 conditional statements. ### Code snippet that reproduces the problem https://phpstan.org/r/3412d834-a20f-4968-aeae-06b6b07e4463 ### Expected output...

Incorrect behavior of TypedPropertyFromColumnTypeRector

1

# Bug Report The default value of `nullable` on `Column` is `false`, so `$bar` and `$baz` below should both be converted the same way, but `$bar` is incorrectly set as...

allow @var phpdocs before return statements

19

This PR stops phpdocs before return statements from being converted to comments, if they are a `@var` definition. This is a common requirement with SA tooling to assist the tool...

[FrameworkBundle] `WebTestCaseTest::assertCheckboxChecked/assertCheckboxNotChecked` does not work with html5

4

### Symfony version(s) affected 6.1, sort of ### Description The [`WebTestCaseTest::assertCheckboxChecked/assertCheckboxNotChecked`](https://github.com/symfony/symfony/blob/8a5b9a27250736a9b38e2bd802c394a2834e7e94/src/Symfony/Bundle/FrameworkBundle/Test/DomCrawlerAssertionsTrait.php#L88-L102) assertions do not work with html5 content. They are only [tested with html 4 content](https://github.com/symfony/symfony/blob/8a5b9a27250736a9b38e2bd802c394a2834e7e94/src/Symfony/Bundle/FrameworkBundle/Tests/Test/WebTestCaseTest.php#L233-L246). If the html tag...