Ben Davies comments

Results 111 comments of


                                            Ben Davies

Bugs with counting total messages processed

think this was broken by https://github.com/zenstruck/messenger-monitor-bundle/commit/a4fc554d0e9a793f404e5f18767f7f4d06258d6d

Add input data to processed messages

awesome feature!

Potential Memory Leak

> > Around the 25%-27%, with 2Gi allocated > > Did you set the `GOMEMLIMIT`? Go will use all available physical memory (not the memory limit!) and it needs to...

Potential Memory Leak

ah, so you're saying the above example is not good as `GOMEMLIMIT` ends up negative so may up using more memory than available?

thanks @withinboredom ! Also note my comments here around workers, threads, php and go memory limits, and how all these things are connected and should be configured: https://github.com/dunglas/frankenphp/pull/1004

`Type\nonnull()` is not narrowed by phpstan

Thanks for looking like that. However, all the other PSL types work like i posted in the OP. i.e. this does not need the dump to be on the line...

Worker Cache does not get updated if worker crashes

ah right, but it's 1 hour not 5 minutes, right? https://github.com/zenstruck/messenger-monitor-bundle/blob/e6a804a80b17388111f9e52eba09d9dfd9743839/src/DependencyInjection/ZenstruckMessengerMonitorExtension.php#L72C44-L72C48

Worker Cache does not get updated if worker crashes

👍

Performance issues when `processed_messages` gets "large"

hi @kbond . I've looked into this. The first query is being produced by `LimitSubqueryOutputWalker` and I could not make it fast with any indexing. `LimitSubqueryOutputWalker` is being used because...

Performance issues when `processed_messages` gets "large"

> To clarify, setting setUseOutputWalkers(false) in zenstruck/collection reduces from 30 seconds to 100ms or the index or both together? calling `setUseOutputWalkers(false)` causes `LimitSubqueryOutputWalker` to not be used which changes the...