Ben Davies

An optional bleeding edge or phpstan-strict-rules rule would be great. I'm always after more strictness! On Thu, 24 Nov 2022, 15:55 Ondřej Mirtes, ***@***.***> wrote: > I'll eventually adopt this...

@bshaffer surely this is **just** (😉) an update to the generator in https://github.com/googleapis/google-api-php-client-services? caveat: I haven't looked at the generator

the [phpstan level](https://github.com/googleapis/google-api-php-client/blob/main/phpstan.neon.dist#L3) could also be increased here, which will expose a lot of incorrect docblock issues.

forgot about this. i'll take a look again

FYI this fix in the fork is here https://github.com/phoenix-actions/test-reporting/pull/8

just came across this. It is madness that `assertJsonEquals` currently ignores keys. I've found a few ignored errors in my testsuite down to this. We should look to get this...

it seems we should be using https://github.com/sebastianbergmann/phpunit/blob/main/src/Framework/Constraint/JsonMatches.php in some way which does the canonicalizing

this seems to do the trick ```php public static function assertJsonEquals(array|string $json, string $message = ''): void { if (\is_array($json)) { $json = json_encode( $json, JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES | JSON_PRESERVE_ZERO_FRACTION...

> Thanks for the report. Does `keep_legacy_inflector: true` solves the issue for now? yes, it does. 👍

@soyuka having thought about this, i think this is tricky to solve. what if we had a Resource like this. ```php #[ApiResource( operations: [ new GetCollection(), ], )] #[ApiFilter(DateFilter::class, properties:...