EntityJS icon indicating copy to clipboard operation
EntityJS copied to clipboard

Assets should return all sounds and assets

Open jlgrall opened this issue 12 years ago • 5 comments

When I do a rspec on an unmodified clone of your repository, I get the following errors:

Failures:

  1) Assets should return all sounds
     Failure/Error: r.should include(@sounds_file.gsub('assets/', ''))
       expected [] to include "sounds/fold/secret1.mp3"
     # ./spec/lib/entityjs/assets_spec.rb:31

  2) Assets should return all assets
     Failure/Error: r.should include(@sounds_file.gsub('assets/',''))
       expected [] to include "sounds/fold/secret1.mp3"
     # ./spec/lib/entityjs/assets_spec.rb:38

Finished in 3.97 seconds
60 examples, 2 failures, 1 pending

Did I do anything wrong ?

jlgrall avatar Feb 12 '13 00:02 jlgrall

I think you're just missing the file. Let me fix that.

bendangelo avatar Feb 12 '13 15:02 bendangelo

Entityjs is currently being redone in grunt and reworked. These issues will be fixed soon.

bendangelo avatar Apr 04 '13 00:04 bendangelo

Yeah, Node.js is better than ruby for a JavaScript library :)

Meanwhile, I started an entity-component-system engine. The idea is close to your EntityJS which is an entity-component engine (and I borrowed some ideas from you, thx), but there are some important differences. Then I will make a game engine around it.

https://github.com/jlgrall/esEngine

jlgrall avatar Apr 04 '13 11:04 jlgrall

It looks cool but it makes more sense for us to work together rather than making two different engines. :)

bendangelo avatar Apr 04 '13 13:04 bendangelo

Thanks.

I do agree that collaboration is better, but unfortunately entity-component-system is quite different from entity-component. For example, no game logic should ever be implemented in a component, which makes it even less tightly coupled than an entity-component design :)

I don't think we can collaborate on the core engine. But as we both have a MIT license, we can get some ideas from each other or reuse parts that are not close to the core of the engines, like asset management. Still as my project is only beginning, it won't be very interesting for you...

When esEngine will be working, I will make another project that uses esEngine to make a simple game framework around it.

jlgrall avatar Apr 04 '13 17:04 jlgrall