MyEntities icon indicating copy to clipboard operation
MyEntities copied to clipboard

Seperate head entities from custom entities

Open inxomnyaa opened this issue 4 years ago • 5 comments

Is your feature request related to a problem? Please describe. The code is getting quite messy since custom entities and head entities share alot of code inside MyCustomEntity.

Describe the solution you'd like I would like to seperate it into HeadEntity, CustomHeadEntity and CustomEntity. (Vehicles could also extend CustomEntity)

This would make several things easier:

  • Constructing the entities
  • What data should be saved
  • The drops of the entity
  • Collisions and scale
  • Skin management
  • Rotation/placement

@benda95280 i need your opinion on this

inxomnyaa avatar Sep 26 '19 10:09 inxomnyaa

In the past, i've try to do it, but it wasn't a success. I was thinking to do it, when i've pushed files for vehicule.

Seems a good idea, but my knowledge is limited here.

benda95280 avatar Sep 26 '19 10:09 benda95280

Cool, i will try my best

inxomnyaa avatar Sep 26 '19 11:09 inxomnyaa

Please, take care of yourself, you don't have to handle all issue ;)

benda95280 avatar Sep 26 '19 12:09 benda95280

I will start it this evening :+1: so #17 can continue. Could be that i include it directly in my change.

Is it okay if old entities break?

inxomnyaa avatar Sep 30 '19 10:09 inxomnyaa

No problem for me. I wait this impressive rewrite :)

benda95280 avatar Sep 30 '19 13:09 benda95280