react-redux-grid icon indicating copy to clipboard operation
react-redux-grid copied to clipboard

Passes pageSize to initial setData call

Open mr-winter opened this issue 7 years ago • 2 comments

Adds pageSize to extraParameters for initial remote setData call. Also gitignores intellij idea folder.

mr-winter avatar Aug 24 '17 04:08 mr-winter

Codecov Report

Merging #174 into master will increase coverage by 0.22%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   75.78%   76.01%   +0.22%     
==========================================
  Files         111      112       +1     
  Lines        5097     5144      +47     
  Branches      366      366              
==========================================
+ Hits         3863     3910      +47     
- Misses        957      958       +1     
+ Partials      277      276       -1
Impacted Files Coverage Δ
src/components/Grid.jsx 80.78% <ø> (+0.59%) :arrow_up:
src/constants/GridConstants.js 68% <0%> (-0.75%) :arrow_down:
src/util/stateGetter.js 89.28% <0%> (-0.37%) :arrow_down:
src/constants/ActionTypes.js 52.22% <0%> (-0.35%) :arrow_down:
src/components/plugins/editor/inline/Button.jsx 76.25% <0%> (ø) :arrow_up:
src/components/layout/TableRow.jsx 71.72% <0%> (ø) :arrow_up:
src/components/layout/TableContainer.jsx 62.5% <0%> (ø) :arrow_up:
src/util/filterUtils.js 93.54% <0%> (ø)
src/store/configureStore.js 77.27% <0%> (+2.27%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d179a4...b8ff485. Read the comment docs.

codecov-io avatar Aug 24 '17 04:08 codecov-io

I know the current test suite is passing, but are there any new tests we should add to check how this new code affects the current implementation or the newly introduced behavior?

bencripps avatar Aug 24 '17 14:08 bencripps