react-redux-grid icon indicating copy to clipboard operation
react-redux-grid copied to clipboard

support different languages

Open mickey159 opened this issue 8 years ago • 4 comments

could you add support for changing the table direction (direction :rtl)?

mickey159 avatar Feb 16 '17 23:02 mickey159

I'm not sure what you mean? Support different languages? Changing direction?

bencripps avatar Feb 17 '17 01:02 bencripps

Do you mean:

text-direction: rtl

If so, how would you see that being implemented. Couldn't you just add the CSS yourself in your app to override the grid behavior?

bencripps avatar Feb 17 '17 01:02 bencripps

Changing text direction will affect only the text, not the other elements of the table. the scrollbar will stay to the left, as well as the menu. Moreover, it would be confusing to change the sizes of the column, because it will be necessary to drag a column from the beginning and not from the end.

mickey159 avatar Feb 17 '17 10:02 mickey159

Hmm yeah, this would be a big fix. I'm open to it, but since this is a heavy change, I will mark this one as help wanted, and get to it as soon as I can.

Thanks!

bencripps avatar Feb 17 '17 14:02 bencripps