github-action-benchmark icon indicating copy to clipboard operation
github-action-benchmark copied to clipboard

support Cargo optional MB/s output

Open seanmonstar opened this issue 1 year ago • 1 comments

In a Rust benchmark, if you specify how many bytes a benchmark is touching, it can output MB/s. This parses and ignores that value.

seanmonstar avatar Jul 09 '24 13:07 seanmonstar

Thank you for your contribution! Could you please add a test case with the MB/s unit that was failing and is passing now?

ktrz avatar Sep 09 '24 08:09 ktrz

Maybe it would make more sense to support arbitrary units instead and extract the unit?

I have a test on this format that fails, for instance:

test cmov ... bench:        2835 cycles/iter (+/- 14)
test cmov2 ... bench:        2845 cycles/iter (+/- 19)
test mov ... bench:        1508 cycles/iter (+/- 17)

xtrm0 avatar Nov 27 '24 18:11 xtrm0

I added support for these changes in #280

xtrm0 avatar Nov 27 '24 18:11 xtrm0

resolved by #280

ktrz avatar Dec 09 '24 18:12 ktrz