github-action-benchmark icon indicating copy to clipboard operation
github-action-benchmark copied to clipboard

Published 20 hours ago • verified publisher icon benchmark-action

Question regarding calculation of percentages in the README

Open dafeda opened this issue 1 year ago • 0 comments

README states the following:

By default, this action marks the result as performance regression when it is worse than the previous
exceeding 200% threshold. For example, if the previous benchmark result was 100 iter/ns and this time
it is 230 iter/ns, it means 230% worse than the previous and an alert will happen. The threshold can
be changed by `alert-threshold` input.
  • Should this be ns/iter and not iter/ns as 230 iter/ns is better than 100 iter/ns?
  • Also, going from 100 ns/iter to 230 ns/iter is a 130% decrease and not 230% right?

dafeda avatar Dec 27 '23 07:12 dafeda