github-action-benchmark icon indicating copy to clipboard operation
github-action-benchmark copied to clipboard

[FR] Set alert threshold per value for more fine-grained control

Open jellespijker opened this issue 2 years ago • 1 comments

We have a workflow which analyzes the output of our product and and sometimes a lower values is better, while other times a higher value is better. https://github.com/Ultimaker/CuraEngine/blob/33790412b61f33e4f4bfe1af2512f2f621e7aff5/.github/workflows/gcodeanalyzer.yml#L181

Allow for alert_threshold to be set per value will give a more fine-grained control

          {
            "name": "Quantity which should not increase",
            "value": 12503.752753577128,
            "unit": "s"
            "alert_treshold": ">110%"
          },
          {
            "name": "Quantity which should not decrease",
            "value": 182291,
            "unit": "-"
            "alert_threshold": "<90%"
          },

jellespijker avatar Aug 12 '23 08:08 jellespijker

Hi @jellespijker

Thank you for filing an issue! Sorry for taking so long to get back to you on this.

I would love to consider this enhancement. Do you know how you would like to configure this behavior? One thing that I'm planning to do is to calculate the "bigger is better" boolean based on the unit. Does your workflow generate output with units that could be used to determine if the bigger or smaller value is better? If so then this could probably be the easiest fix for this

ktrz avatar Apr 03 '24 07:04 ktrz