bob icon indicating copy to clipboard operation
bob copied to clipboard

Remove artifact store interface

Open zuzuleinen opened this issue 3 years ago • 1 comments

We can remove Store interface

Following reasons:

  1. Clean() is implemented only on the local, Done only on the remote
  2. ctx was added to the interface only for the remote store purpose
  3. In the code they are always used separately so no polymorphism is happening.
  4. existence of "not implemented" methods on both implementations

1 & 2 show they really are different behaviours so no benefit of having this interface. Adding new functionalities to one implementation forces us to add params to the second one.

zuzuleinen avatar Jun 24 '22 12:06 zuzuleinen

In the process of removing the shared Store interface it would also be good to remove and avoid the package name store and use more specific names like localartifactstore or remoteartifactstore etc.

dketterer avatar Jul 12 '22 07:07 dketterer

Wanted to implement this in https://github.com/benchkram/bob/pull/227, but didn't get an approval from @Equanox

Will close this

zuzuleinen avatar Dec 19 '22 12:12 zuzuleinen