bencher icon indicating copy to clipboard operation
bencher copied to clipboard

allow disabling warnings for missing thresholds

Open kaspar030 opened this issue 1 year ago • 3 comments

I'm suddenly getting huge warnings for a missing threshold, e.g., here: https://github.com/kaspar030/laze/pull/553#issuecomment-2467960991

I did specifically not set one up as github's workers are too inconsistent to provide meaningful results (I got too many false negatives).

Is there a way to disable the warnings?

kaspar030 avatar Nov 11 '24 11:11 kaspar030

@kaspar030 sorry you're running into this.

Would having a --no-thresholds flag or something be useful here?

In the mean time, you can create a threshold and then just clear the model right after you create it. This should get rid of the warning but not clutter up the results the same way that creating an extremely high/low threshold would.

epompeii avatar Nov 11 '24 13:11 epompeii

I'm hitting this again, after fixing it last time with a fake threshold.

Would having a --no-thresholds flag or something be useful here?

yes, I think so. I'm happy with just seeing the difference to the running average.

kaspar030 avatar Feb 24 '25 13:02 kaspar030

@kaspar030 sorry I missed your update. Are you still seeing this? If so, do you have a link to a project where this is happening?

Creating a Threshold should get rid of the warning. Old PR comments will still show the warning, but new ones shouldn't have it.

epompeii avatar Apr 05 '25 15:04 epompeii