bencherdev
Improve Threshold and Alert UI
Currently the selection of Thresholds and the presentation of Alerts is rather... clunky to say the least. Design and implement a much more intuitive UI for selecting Thresholds and displaying standalone Alerts (that is outside of the Perf Plot view).
It would be great if the Alert UI would include a link to the offending commit. E.g. when looking at a plot, clicking on the alert takes me to this page , which does not contain any information like the commit. currently I look at the time and manually search for matching commits.
@jschwe I totally agree. It would be great to have this on the Alert page itself.
There is also a bug here. Even now, you should be able to:
- Pull up the Alert
- Click the link to the Branch
- Click the link to the version hash
- It will pull up the commit in GitHub*
*Note for Future Travelers: This would work because the Servo Project URL is set to its GitHub repo.
Right now, the link used in step 2 is adding the head query param, as expected: https://bencher.dev/perf/servo/branches/main?head=3dbe3681-11b1-4e30-b482-4ee72dc0960c
But we aren't getting the Branch at that head. I'll investigate!
@jschwe it turns out that I was misremembering. Previously, the branch version hash would only appear on the metrics page. So if you clicked a dot on the perf plot, the hash would show up there: https://bencher.dev/console/projects/servo/metrics/77f22978-447a-4a6c-b94b-bce88bfd11de
With that said, I have updated things so now the branch head version will appear on both the Report and Alert pages as well. Let me know what you think!