bencher icon indicating copy to clipboard operation
bencher copied to clipboard

In Perf Plot add clicking on metric to view commit

Open epompeii opened this issue 2 years ago • 2 comments

epompeii avatar Aug 16 '23 16:08 epompeii

I don't know if it's the perfect place to comment, but it would be nice to have also the benchmark name in every metric popup (when hovering with mouse).

GitGab19 avatar Aug 16 '23 16:08 GitGab19

Definitely!

It may also be useful to include the testbed as well, if a user is comparing the same benchmark across different testbeds.

epompeii avatar Aug 16 '23 16:08 epompeii

I'd also be interest in easier ways to get access to metadata of single benchmark results from a plot. Right now the commit SHA is shown in a point hover, but there is no easy way to copy it to pivot to the commit on the command line (getting directly to the commit in e.g., GitHub might also be interesting, but IMO that would not be as generally useful). There is also #128 which could benefit from some way to display the data for copying.

bbannier avatar Jun 18 '24 07:06 bbannier

@GitGab19 and @bbannier I have implemented a way to do this. You can now click on any Metric in the Perf Plot (the round dots), and it will show you a detailed view for that Metric. For example, this is a recent Metric.

If you have your Project's url set to a GitHub repository then it will turn the git hash in the Metric view into a link auto-magically. For example, the Bencher project has its url set to https://github.com/bencherdev/bencher, and the hash in the example above is a link to the commit on GitHub.

Please, let me know what you think!

epompeii avatar Jun 22 '24 12:06 epompeii

Completed: https://bencher.dev/docs/reference/changelog/#v0414

Feel free to keep the discussion going here though. I'm more than happy to refine things and make breakout tasks.

Update: There was a bug in the initial implementation that caused the dedicated Metrics pages to 404 when viewed from the Console. This has been fixed in the next release: https://bencher.dev/docs/reference/changelog/#v0415 Thank you , @bbannier for the bug report.

epompeii avatar Jun 22 '24 14:06 epompeii

Awesome @epompeii 👏 I will take a look at it asap, thank you!

GitGab19 avatar Jun 24 '24 10:06 GitGab19