hnews
hnews copied to clipboard
bencevans
Add hidden link to comments
When listing news, if your terminal can detect and open URIs, now you can just click next to the "... comments ... ago" line, to open the comments' page in the browser
This change is 
OTOH https://chrome.google.com/webstore/detail/read-the-effing-article/angdimfeecdnooacbnnppmlbobcnpbln/details :)
Looking at the output, I'm not sure this is a great idea to be honest.
What I propose is make the links an opt in feature. So we create a config file in the users home directory ~/.hnews with either JSON, YML or INI formatting have commentlinks=true and itemlinks=true to enable.
Thoughts?
I mean the output isn't great if your terminal can't fit links on the same line as the content.
:) I expected this feedback on my previous PR
Indeed, it's not pleasant, but since hnews is tiny (and I like it), maybe just an arg is enough hnews home --showlinks ?
Sounds good to me, although I think using a config file might be nice for users that want the links all the time. On 18 Feb 2014 18:12, "Andrei Neculau" [email protected] wrote:
:) I expected this feedback on my previous PR
Indeed, it's not pleasant, but since hnews is tiny (and I like it), maybe just an arg is enough hnews home --showlinks ?
Reply to this email directly or view it on GitHubhttps://github.com/bencevans/hnews/pull/8#issuecomment-35414767 .
Hi @andreineculau,
Have you had the oppertunity to add flag options?
Cheers, Ben
No :( and I probably won't find the time in the near future
Maybe this should just be reverted?!
On Tue, Apr 8, 2014 at 11:43 AM, Ben Evans [email protected] wrote:
Hi @andreineculau https://github.com/andreineculau,
Have you had the oppertunity to add flag options?
Cheers, Ben
— Reply to this email directly or view it on GitHubhttps://github.com/bencevans/hnews/pull/8#issuecomment-39829386 .
andreineculau.com http://www.andreineculau.com