Overmind icon indicating copy to clipboard operation
Overmind copied to clipboard

cherry pick: 0 = false, check for key exists. stop moving managers

Open ikiris opened this issue 4 years ago • 1 comments

Pull request summary

Description:

Manager was getting pushed, debuged to this logic bug that 0 fails the test intended to check if the element exists. Replaced with equivalent test logic.

Fixed:

MovePush check incorrectly treating manager 0 value as nonexistent and taking default 10 causing unintended push.

Testing checklist:

  • [x] Changes are backward-compatible OR version migration code is included
  • [x] Codebase compiles with current tsconfig configuration
  • [x] Tested changes on PUBLIC server OR changes are trivial (e.g. typos)

ikiris avatar May 27 '20 16:05 ikiris

in the master branch, the manager had a value of 1 for a priority, this PR fixes it.

zGeneral avatar Oct 14 '20 13:10 zGeneral