Ben Briggs

Results 31 comments of Ben Briggs

Yep that first paragraph was pretty much what I was thinking. I hadn't thought about nesting the same semantic tag though - you're right it wouldn't get the underline color...

Can you elaborate a bit more on what precisely you're seeing? By breaking rendering do you mean an exception being thrown? An example test asserting an expected output would be...

Yup! I'll be more specific on how it'd be consumed - when converting from HTML you could do something like this: ``` const contentState = convertFromHTML({ ignoreElement: (nodeName, node, lastList,...

could you intercept your paste function to check what the incoming HTML string is in your case, then send that and the resulting (raw) content state that `convertFromHTML` returns?

@optimatex when looking in the draft source recently i came across https://github.com/facebook/draft-js/pull/1378 - i think this is the culprit (and is a relief because a specific emoji appearing sounded mystifying)....

@jisaacks is your entity within an `atomic` block? if so [this case](https://github.com/HubSpot/draft-convert/blob/master/src/convertFromHTML.js#L389-L396) should be covering your issue.

Sorry, subsequent changes to the file moved the highlighted area, here's a [permanent link](https://github.com/HubSpot/draft-convert/blob/3ad21559078125116557189e2e38ee428ce38f1a/src/convertFromHTML.js#L400-L407) to what I meant to highlight. When using atomic blocks and an entity is within the...

As a side note I hope to in the somewhat near future write more documentation about specific patterns like dealing with atomic blocks as well as some more in-depth best...

i'd recommend instead of using different block types, instead using an `atomic` block type for anything that isn't editable via traditional typing (besides when deleting the block) and using something...

i don't currently - i've played around with adding flow annotations since draft-js uses flow. our internal stack doesn't include either currently but from what i understand we're most likely...