spherely icon indicating copy to clipboard operation
spherely copied to clipboard
verified publisher icon benbovy

Align GeographyType values with shapely.GeometryType

Open benbovy opened this issue 11 months ago • 1 comments

Replaces #90 (automatically closed by deleting target branch != main). Closes #88.

benbovy avatar Feb 04 '25 14:02 benbovy

Whichever we choose, it should always be recommended to compare with the enum and not with a direct integer, and if you follow that then the actual number does not matter too much.

I agree, however there's no easy way to support that here (https://github.com/benbovy/spherely/pull/51#discussion_r1797638051) so we have to stick with comparing values for now (hence this PR and #88).

That said, aligning with WKB is a good point (I didn't know about that) and probably better than aligning with shapely? I'll leave this PR and #88 open and move on with the 0.1.0 release.

benbovy avatar Feb 14 '25 08:02 benbovy