spherely icon indicating copy to clipboard operation
spherely copied to clipboard

Add centroid, boundary and convex_hull function (returning new Geography)

Open jorisvandenbossche opened this issue 3 years ago • 2 comments

jorisvandenbossche avatar Mar 08 '23 21:03 jorisvandenbossche

Codecov Report

Patch coverage: 44.73% and project coverage change: -1.46 :warning:

Comparison is base (e874e60) 56.07% compared to head (91ce98f) 54.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   56.07%   54.61%   -1.46%     
==========================================
  Files           5        6       +1     
  Lines         214      249      +35     
  Branches       95      114      +19     
==========================================
+ Hits          120      136      +16     
  Misses          7        7              
- Partials       87      106      +19     
Impacted Files Coverage Δ
src/geography.cpp 41.66% <ø> (-0.27%) :arrow_down:
src/accessors-geog.cpp 37.93% <37.93%> (ø)
src/geography.hpp 83.33% <50.00%> (-4.17%) :arrow_down:
src/pybind11.hpp 82.14% <75.00%> (-0.47%) :arrow_down:
src/spherely.cpp 57.14% <100.00%> (+7.14%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Mar 18 '23 19:03 codecov[bot]

@benbovy this should be ready I think. There are certainly some things to improve (easier testing, correct return class), but those can be left for follow-ups I think.

jorisvandenbossche avatar Mar 18 '23 20:03 jorisvandenbossche