Benoit Bovy
Benoit Bovy
Alternatively to subclasses, we could reuse the same classes with specialized factories (e.g., `trimesh::from_latlon()`). Pros: - Keep the number of classes small (for the Python bindings, we need to register...
> do we want / need all those subclasses? or at least when adding them, we should be able to answer for ourselves why we do it / what value...
> the R s2 package also doesn't expose any subclasses to the R user, so from their perspective, I think having those subclasses in s2geogrpahy is less important This is...
Thanks for your input @paleolimbot. Yes it makes sense that s2geography provides subclasses that are designed around flexible storage. I think that emulating `Point`, `LineString`, etc. is important for an...
> I see a lot of C++ in https://github.com/benbovy/spherely/pull/26 and I wonder if you actually want is a pure Python hierarchy (backed by an array of Geography that have possibly...
> Maybe something to also discuss more generally: do we want / need all those subclasses? Do you mean that alternatively we could expose only one `Geography` class (with a...
Another alternative would be to expose a unique class for `Point` vs. `MultiPoint`, `LineString` vs. `MultiLineString`, etc. like in s2geography. - this also departs from Shapely's API - I'm wondering...
@jorisvandenbossche I'm moving forward with the implementation of the Geography subclasses here but this shouldn't prevent us from discussing how best to expose these (maybe in a separate issue?). I...
I haven't checked if shapely copies the input geometries when creating a collection... Here that's a requirement if we want to reuse `s2geography::GeographyCollection` (which owns its features). I added a...