Benoit Bovy

Results 452 comments of Benoit Bovy

Mmm now I'm confused about the validity of kd-tree + haversine. I'm wondering why haversine is not in the list of valid metrics for scikit-learn's KDTree. We ~~should~~ might also...

Sorry for the late reply @dcherian! Yes, I think it would be nice to support selection of a single point with something more convenient than the workaround you've shown.

I think that the "hashing / buckets" approach using H3 cells described in #16 could probably help in this case. We could choose a H3 cell resolution that is the...

`pyresample` uses [pykdtree](https://github.com/storpipfugl/pykdtree) under the hood, which looking at the benchmarks is faster than `scipy.spatial.cKDTree`. It can support parallel queries (using openmp) but seems to only support euclidean distances.

> is faster than scipy.spatial.cKDTree Maybe not anymore? https://github.com/ESM-VFC/xoak/issues/12#issuecomment-672756670

Hi @djhoese! Hope to clarify things a bit about Xarray flexible indexes and Xoak here. We started Xoak as a preliminary project before starting to work on flexible indexes in...

> Does that mean that this entrypoint system doesn't exist yet for index registration? In Xarray indeed there's no API or system yet for registering or even using custom indexes...

@keewis could you upload some screenshots? It will be easier for the review. A more general comment: why not having a clearer distinction between the data sections and the tree...

> my knowledge of HTML and CSS is pretty limited, so I just used whatever was already available in xarray. No worries! The second screenshot looks already pretty nice. I'd...

> Build a hash-table so that we can retrieve the original data points (positional index) from the computed H3 index values. Not sure at all about this part, though. Would...