Benoit Bovy

Results 452 comments of Benoit Bovy

> We could expose a global option in Xarray-simlab so that the two functions above are implicitly called in xsimlab variables' getter/setter properties Or maybe the right place to expose...

Just to say that I'm sorry for the long wait and for my absence of reaction so far @Joeperdefloep! I've been struggling these last months to get to review your...

Hi @Joeperdefloep, yes sorry (again), this is still on my radar. I've been busy with other projects, notably a big refactor in Xarray to allow custom and explicit indexes, but...

Hi Jean, The first issue is a bug (thanks for reporting it): in the line below the shift value should be -1 instead of 1. https://github.com/xarray-contrib/xarray-simlab/blob/33a4c83b3046153ff4a63c44925d67b54d42beb0/xsimlab/drivers.py#L175 The second issue is...

> To understand the aim correctly: Is the order that processes are added to the model recorded, and the processes will be initialized in that order at runtime? Or is...

Sorry for the late reply @jvail ! Yes it would be nice if xarray-simlab could support sparse arrays (I haven't tried yet). Xarray-simlab uses `zarr` to store the model outputs...

Hi @jvail, Thanks for your example. Calling `todense()` before writing to zarr (and issue a warning) seems reasonable to me. It's better than no support at all. Hopefully, better support...

> Unfortunately I could not get it working with the "infamous" mask_and_scale: True setting. Maybe you have an idea? Without having looked at your branch yet, my first idea would...

I just had a look at your https://github.com/jvail/xarray-simlab/commit/cfa37a69796985beca19ffadcef70d8005ccb1d7 branch. That's nice! I think that such support for sparse arrays would be a nice addition in xarray-simlab before proper support for...

Yes generally I'm d'accord ! Do you have an idea how to fix the mask_and_scale: True issue? Could it be that now xarray does complain about structured arrays coming from...