litestream icon indicating copy to clipboard operation
litestream copied to clipboard

Re-implement Windows support

Open chakflying opened this issue 2 years ago • 11 comments

Hi. I'm looking into integrating this in uptime-kuma, but currently this does not build on Windows, which is a pretty significant portion of the users. Would be great if this gets officially supported again. Thanks!

Edit: looks like #369 may already fix this, if so you can disregard.

chakflying avatar May 10 '22 02:05 chakflying

Hi @chakflying, issue #369 is just including support for fsnotify (which itself supports Windows). I don't have any immediate plans to re-add Windows support but I'll leave this issue open. It's mostly that I lack the expertise and time to actually have this run well on Windows.

benbjohnson avatar May 10 '22 14:05 benbjohnson

@benbjohnson Assuming the fsnotify is fixed for windows, what are the the other blockers for Windows ? If they can be listed we can get some light / eyeballs on them.

gedw99 avatar May 13 '22 15:05 gedw99

There aren't any large technical hurdles for Windows support but the usage numbers for Windows are quite small and I didn't feel comfortable releasing and maintaining the Windows code since CI is not setup to run it. It ended up being a lot of little hassles in order to try to support a small number of users.

benbjohnson avatar May 13 '22 21:05 benbjohnson

thanks @benbjohnson

i am using litestream on desktops and hoping to use on Windows. But yeah i see your point about lack of users on Windows.

The reason i asked if there are currently well known blockers was only to get an LOE gut instinct for how much of a PITA Windows will be.

gedw99 avatar May 16 '22 15:05 gedw99

First I wanted to thank @benbjohnson and the community for a useful and great project. I am working in a small group that develops services on top of windows 10/11/Server. I find that the project suits our needs. The only worry that I have is that future versions will not support windows.

I really hope that you will consider returning the windows support (maybe in a lower release rate) so all of us who still use it will be able to enjoy the litestream project

MMWPF avatar Aug 01 '22 04:08 MMWPF

Yes, thanks @benbjohnson and the community. I was planning to use litestream on Windows EC2 instances. Looks like it's best for me to have a stab at compiling the sources myself and wrapping the output in TopShelf to form a windows service.

peteryancallglide avatar Aug 03 '22 15:08 peteryancallglide

Also am interested in running on windows . Will be happy to help if needed .

gedw99 avatar Aug 03 '22 15:08 gedw99

Hi,

I am running Litestream on Windows through source compilation and was able to successfully replicate the db file.

But, one interesting observation was that when I replicated my DB file from Windows machine to S3, I was only able to restore it on Windows machine but was not able to restore on Mac OS. And same behaviour when I replicate on Mac OS and try to restore it on Windows.

Is this expected or am I missing something? Appreciate any help on this and also not sure if I should be moving this discussion to a different thread.

arjunpola avatar Aug 04 '22 07:08 arjunpola

@arjunpola What error are you seeing? I wouldn't expect that restores on a different OS to make a difference.

benbjohnson avatar Aug 06 '22 14:08 benbjohnson

hey everybody, would making Litestream available as a runtime-loadable extension work on the Windows side? I'm not much of a Windows developer and trying to do testing and debugging was difficult and time consuming. Maybe an extension would be an easier approach.

benbjohnson avatar Aug 06 '22 14:08 benbjohnson

@arjunpola What error are you seeing? I wouldn't expect that restores on a different OS to make a difference.

no matching backups found

I get the above error when I try to restore on MacBook a database that is backed from Windows. But, I realised the versions of litestream were different and for some reason it had not created a generation file. After updating to the latest release. The issue was resolved.

@benbjohnson Thanks a lot :)

arjunpola avatar Aug 07 '22 13:08 arjunpola

Windows support should work again if built from git. If anyone in this issue could confirm it works fine I'll close this.

It's not supported right now because there's no Windows maintainer but it at least builds for now.

hifi avatar Dec 27 '23 15:12 hifi

I am using litestream on windows. Built from source and it works all fine.

arjunpola avatar Dec 27 '23 16:12 arjunpola

Thanks for confirming!

hifi avatar Dec 27 '23 16:12 hifi