RecordStream
RecordStream copied to clipboard
move to RewriteVersion because it will install on newer Perls
Hi!
I received your module as part of this month's CPAN PR-Challenge. Making use of RewriteVersion gets rid of the following problem when trying to build on newer Perls with Dist::Zilla:
$ cpanm Dist::Zilla::Plugin::VersionFromModule
--> Working on Dist::Zilla::Plugin::VersionFromModule
Fetching http://www.cpan.org/authors/id/C/CJ/CJM/Dist-Zilla-Plugins-CJM-4.27.tar.gz ... OK
Configuring Dist-Zilla-Plugins-CJM-4.27 ... OK
Building and testing Dist-Zilla-Plugins-CJM-4.27 ... FAIL
! Installing Dist::Zilla::Plugin::VersionFromModule failed. See /Users/cwhitener/.cpanm/work/1473390305.53210/build.log for details. Retry with --force to force install it.
Thanks, Chase
Thanks a bunch for the contribution. Do you know if this can be tested on travis, if so I'd like to make sure this is a part of that. Also @tsibley knows a bunch more about our dist build process at this point, perhaps he would like to chime in?
Hmm, it seems like the underlying problem is with the VersionFromModule plugin: https://rt.cpan.org/Public/Bug/Display.html?id=116902
There are two outstanding PRs to fix VersionFromModule which were recently (~month or two) filed: https://github.com/madsen/dist-zilla-plugins-cjm/pulls
@genio Thanks for looking into this! Did you have a chance to test the dist build/release cycle with your changes? We should verify that RewriteVersion + ReversionOnRelease play nice together since RewriteVersion both provides and updates versions where as VersionFromModule only provides (letting ReversionOnRelease do the updates).