jekyll-titles-from-headings icon indicating copy to clipboard operation
jekyll-titles-from-headings copied to clipboard

Remove check for collection type from the strip_title_exerpt? function

Open staticintlucas opened this issue 2 years ago • 3 comments

Remove the check for collection type when determining whether to strip the title from the excerpt. Fixes #81

I'm not super familiar with Jekyll so not sure if this will have any unintended side effects. It seemed to work fine in my testing though.

staticintlucas avatar Mar 03 '22 20:03 staticintlucas

Welcome! Congrats on your first pull request to Jekyll Titles From Headings. If you haven't already, please be sure to check out the contributing guidelines.

welcome[bot] avatar Mar 03 '22 20:03 welcome[bot]

It looks like this was implemented in https://github.com/benbalter/jekyll-titles-from-headings/pull/28. @qwtel do you recall why posts are special cased and what change in behavior, if any, removing it might have?

benbalter avatar Mar 03 '22 20:03 benbalter

@qwtel @benbalter Any movement on this?

From what I can tell the only difference between posts and any other collection is that by default posts has output: true to generate individual pages. But this is already taken into account by iterating over site.pages which will not include any collections with output: false.

FWIW my original issue would also have been fixed by PR #64, so if you prefer you could merge that instead.

staticintlucas avatar Mar 22 '22 23:03 staticintlucas