benCoding.AlarmManager icon indicating copy to clipboard operation
benCoding.AlarmManager copied to clipboard

When API >= 26 you have to use NotificationChannel

Open michielvaneerd opened this issue 6 years ago • 9 comments

When API >= 26 you have to use NotificationChannel otherwise notifications don't work anymore. This pull request adds NotificationChannel support and makes notifications work again. Other small changes:

  • Small improvement with repeated notifications
  • Update documentation

michielvaneerd avatar Jul 13 '18 11:07 michielvaneerd

I think people are going to run into this more now that Google is starting to require min api 26. Previous version of the module will fail silently.

adampax avatar Sep 17 '18 15:09 adampax

Yes I have experiences. I have build an other module with PN, Next days I will look into.

AppWerft avatar Nov 30 '18 16:11 AppWerft

Maybe TaskScheduler is a better idea for starting processes later. http://www.vogella.com/tutorials/AndroidTaskScheduling/article.html

AppWerft avatar Nov 30 '18 16:11 AppWerft

Thanks @michielvaneerd your PR works fine, but I've an issue: when I click on the notification icon, the app shows this alert dialog:

Restart Required An application restart is required

CONTINUE

and the app don't restart anymore

Astrovic avatar Jan 25 '19 18:01 Astrovic

@Astrovic For me it's working. If you can share the code for a runnable example I can have a look.

michielvaneerd avatar Jan 26 '19 07:01 michielvaneerd

@michielvaneerd I solved by adding this property on tiapp.xml:

<property name="ti.android.bug2373.finishfalseroot" type="bool">true</property>

Astrovic avatar Jan 26 '19 11:01 Astrovic

Is someone merging this?

chmiiller avatar Feb 13 '19 16:02 chmiiller

https://github.com/michielvaneerd/benCoding.AlarmManager/blob/master/dist/bencoding.alarmmanager-android-2.0.0.zip

Astrovic avatar Feb 13 '19 16:02 Astrovic

thanks for sharing @Astrovic and @michielvaneerd , maybe someone could have the official github repo and make it the upstream version later?

chmiiller avatar Feb 14 '19 10:02 chmiiller