Ben Allfree

Results 112 comments of Ben Allfree

@atikenny I confirm the same thing exactly. @razorman8669 Definitely not related to #6735. According to `git bisect`: Bad commit: https://github.com/puppeteer/puppeteer/commit/f863f4bfe015e57ea1f9fbb322f1cedee468b857 Previous commit (good): https://github.com/puppeteer/puppeteer/commit/2c9ff4feafdad31120aa25c30f03ea4c84a88857 Changing from Chromium `869685` to `884014`...

Update for everyone - The issue is `Fetch.requestPaused` gets fired twice by CDP even though only one `Network.requestWillBeSent` is fired. The way NetworkManger is written, it assumes a 1:1 interaction...

I have a PR started to address this issue. Please test it if you can https://github.com/puppeteer/puppeteer/pull/7802.

@dekelev I'm the author of `enchant-pupeteer` and recommend upgrading Puppeteer instead if possible. The enchantment never worked as well as the final stuff merged into the core.

@dekelev I'd get in contact with `puppeteer-extra` and see where they're at with implementing cooperative mode. https://github.com/berstend/puppeteer-extra/pull/592 https://github.com/berstend/puppeteer-extra/issues/364

@rudolfbyker it’s probable you’re experiencing an underlying CDP bug, not something in Puppeteer or higher level libraries. Please check out this and related tickets for more details. The minimal example...

@sindresorhus Thank you for the feedback. After playing with it a bit more, I think I misunderstood my own use case. Closing. For anyone who finds their way here, it...

@papb `not losing information` expresses it perfectly. Or put another way, a type that guarantees the result of JSON.parse is compatible with the type before JSON.stringify. For example, `{foo: ()=>string}`...

Array types like `(string|undefined)[]` are thorny because `JSON.parse(JSON.stringify(['a', undefined, 'b']))` becomes `['a', null, 'b']` on the other side and `null` is not assignable to `undefined`. This is where `PartialDeep` was...

@papb Consider also whether `recurseIntoArrays: false` should be the default. I think it probably should be, because it feels unexpected to make array elements nullable rather than just the keys....