System.Ben icon indicating copy to clipboard operation
System.Ben copied to clipboard

Removes single quotes from README.md

Open bjorkstromm opened this issue 7 years ago • 4 comments

Removes single quotes from README.md so that it works with our custom tool that inserts README file content to a SQL DB.

ping @benaadams

bjorkstromm avatar Mar 22 '17 19:03 bjorkstromm

This is a must for us!!!

The README content of all third party dependencies that we use must be added to our SQL Database. And now we can't do that since it includes single quotes!!!!

bjorkstromm avatar Mar 22 '17 19:03 bjorkstromm

Why is this not merged yet? Do I need to submit an issue?

bjorkstromm avatar Mar 22 '17 19:03 bjorkstromm

I think your db has a SQL injection issue

benaadams avatar Mar 22 '17 20:03 benaadams

@benaadams no? SQL Injection? It's not my tool that is wrong, it's your README file that's not compatible, please accept this PR so I can use this library in our software.

Always the same, Github repos with non-working README files and people with apostrophes in their names complaining on how we sanitize our SQL statements.

bjorkstromm avatar Mar 22 '17 20:03 bjorkstromm