gradle-versions-plugin icon indicating copy to clipboard operation
gradle-versions-plugin copied to clipboard

Published 20 hours ago • verified publisher icon ben-manes

Some Android Gradle Plugin Configuration are not checked any more

Open chrimaeon opened this issue 4 years ago • 4 comments

Since 0.28 some configuration from the Android Gradle Plugin are not checked any more.

I.e. lintCheck and lintPublish

See my comment on the commit to master: https://github.com/ben-manes/gradle-versions-plugin/commit/1c6627ecc8d6f49ab89d5b7e73770ee9a9b03799#r37631016

chrimaeon avatar Mar 04 '20 12:03 chrimaeon

Forwarding discussion from https://github.com/ben-manes/gradle-versions-plugin/commit/1c6627ecc8d6f49ab89d5b7e73770ee9a9b03799#commitcomment-37635505

chrimaeon avatar Mar 04 '20 16:03 chrimaeon

Hmmm, I didn't think of that. Maybe the right approach is to exclude anything with Classpath in it instead of using a whitelist.

SUPERCILEX avatar Mar 04 '20 19:03 SUPERCILEX

Thanks for the explanation @chrimaeon. It makes sense that plugin authors would want to use this to manage versions. And then plugin users would not want to see them in the report because they don't have control of the versions if they are internal to the plugin.

Does that mean it makes most sense to have a flag to control whether internal configurations are resolved, for plugin authors, or not, for plugin users? Admittedly it might be too little benefit for the cost of a flag.

anuraaga avatar Mar 05 '20 04:03 anuraaga

It's not about plugin authors. We have many projects where we define our own plugins within the project.

I'd vote for the flag - let the user of your plugin decide what he wants to have resolved. 👍

chrimaeon avatar Mar 08 '20 16:03 chrimaeon