caffeine icon indicating copy to clipboard operation
caffeine copied to clipboard

fix minor issue with array length condition in object storage traces

Open guykhazma opened this issue 3 years ago • 2 comments

This PR fixes a minor issue with the condition checking for GET requests without range reads.

In addition, since the reader filters only GET requests, I am not sure that the condition is needed at all, I haven't seen any GET request in the traces without range reads so it seems that this condition was never met anyway. Maybe @ohadeytan knows if there are such cases.

guykhazma avatar Nov 09 '22 16:11 guykhazma

Good catch. I believe they weren't such cases, so the condition is indeed redundant.

ohadeytan avatar Nov 09 '22 17:11 ohadeytan

nice, can you delete / rewrite the code @guykhazma to what you think is a clean and correct parser? I'll merge once you give me the okay.

ben-manes avatar Nov 09 '22 17:11 ben-manes

@ben-manes done, I have removed the unnecessary code, thanks.

guykhazma avatar Nov 09 '22 18:11 guykhazma