ben-e-whitney
ben-e-whitney
@qliu21, please hold off on merging this until we discuss it at a Tuesday meeting. This issue has come up in my rewrite of the Huffman compression code. @JasonRuonanWang, were...
> Are `std::int64_t` and `long int` not the same type on your architecture? See [this error][failed static assertion] encountered in #189. [failed static assertion]: https://github.com/CODARcode/MGARD/issues/189#issuecomment-1179556947
I am in the process of rewriting `huffman_encode` and `huffman_decode`. I will collect in this comment a few easily-summarizable issues I encounter in the course of that task. * In...
It appears that those assertions have been there since [the beginning][early assertion]. Let me not speak for @tugluk, but I'd guess that they're just sanity checks. There isn't any mathematical...
@tugluk's comments on #31 and #33 made me realize I wasn't considering the quantizer at all. Without digging into the code, here's roughly what I think's going on: 1. The...
The reimplemented `compress` function added in 6b43966ea2735e803bd5d814a0d5c109402e8efe returns an object containing the compressed data along with the parameters passed to the function. I think we will probably add a member...
@qliu21, please don't merge this pull request yet. I'll rebase once you merge #194 and #195.
@JieyangChen7, I am going to need a little bit of help getting this pull request ready to merge. I just rebased on #197. When I try to build, I get...
@JieyangChen7 Thanks for all the help. > There is one minor change needed. Since the new compress API returns `mgard::MemoryBuffer`, which requires me to indirectly include `"utilities.hpp"`, it triggers the...
@JieyangChen7 I modified `include/mgard-x/CompressionHighLevel/Metadata.hpp` by replacing `std::int64_t` with `QUANTIZED_INT` in a few places in the commit I just pushed (4ef023d0affabc2023ab3c575af9c798055ac8d9). Please give those changes a quick look. I'm still working...